Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Roassal to v1.06 #16287

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Mar 11, 2024

## What's Changed
* Reimplement some explicitly required methods to speed up shapes by @jecisc in pharo-graphics/Roassal#54
* Make RSAthensMorph apply the world renderer canvas scale factor by @Rinzwind in pharo-graphics/Roassal#56
* Added .gitignore file and Removed DS_Store file by @jordanmontt in pharo-graphics/Roassal#57
* Feature add relative y axis label values by @jordanmontt in pharo-graphics/Roassal#58

## New Contributors
* @jecisc made their first contribution in pharo-graphics/Roassal#54
* @jordanmontt made their first contribution in pharo-graphics/Roassal#57

**Full Changelog**: pharo-graphics/Roassal@v1.03...v1.06
@MarcusDenker
Copy link
Member

MetacelloNotification: Project: Tonel
MetacelloNotification: Project: LibGit
MetacelloNotification: Loaded -> BaselineOfLibGit --- unresolved
Instance of Protocol did not understand #isEmptyOrNil
Protocol(Object)>>doesNotUnderstand: #isEmptyOrNil
MCMethodDefinition>>initializeWithClassName:classIsMeta:selector:category:timeStamp:source:
MCMethodDefinition class>>className:classIsMeta:selector:category:timeStamp:source:
CompiledMethod>>basicAsMCMethodDefinition
CompiledMethod>>asMCMethodDefinition

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Mar 12, 2024
@MarcusDenker
Copy link
Member

very strange, this PR can not be the reason for the DNU (Protocol(Object)>>doesNotUnderstand: #isEmptyOrNil)

@jecisc
Copy link
Member Author

jecisc commented Mar 12, 2024

Something seems weird because the build loads the package Roassal-Pharo that breaks Pharo 12 and seems to be the origin of the problem. But in the baseline it should be loaded only in Pharo 11. So I don't get why it is loaded here

@jecisc
Copy link
Member Author

jecisc commented Mar 12, 2024

I think I found the problem but the baseline of roassal seems a little like a mess because it is redefining everything for each Pharo version instead of having a common base and adding some specificities on some Pharo versions

@MarcusDenker MarcusDenker removed the Status: Need more work The issue is nearly ready. Waiting some last bits. label Mar 12, 2024
@MarcusDenker MarcusDenker merged commit 8adaac9 into pharo-project:Pharo12 Mar 12, 2024
1 of 2 checks passed
@jecisc jecisc deleted the misc/roassal branch March 12, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants