Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加系统URL,让管理员可以设置统一的网站URL,避免依赖于浏览器URL的安全问题 #350

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bowang
Copy link

@bowang bowang commented Apr 22, 2022

一个文档被修改时,现在产生的提醒邮件里的 “阅读文档” 按钮的 URL 通过 this.Ctx.Input.Site() 生成,这依赖于浏览器的访问URL

如果一个恶意用户在其本地修改 /etc/hosts,将 wiki 的 IP 重定位到一个恶意网址 http://xxx:1234 ,然后修改某个wiki页面,那么MM-Wiki 给关注该页面的用户发送邮件,邮件里会使用该恶意网址 http://xxx:1234/document/index?document_id=123 ,用户点击链接会去到 http://xxx:1234 ,然后可能会被钓鱼。

本 PR 允许管理员设置统一的访问链接,以解决依赖访问URL来获取wiki网址存在安全问题。

@bowang bowang changed the title 添加系统URL,让管理员可以设置统一的访问链接,避免依赖于访问URL导致的安全问题 添加系统URL,让管理员可以设置统一的网站URL,避免依赖于浏览器URL的安全问题 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant