fix: support bytea in preferQueryMode=simple #3243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds text encoding for
bytea
.Interestingly, the tricks with
private final char[] hexDigits
do not improve performance, and we probably should stick withCharacter.forDigit(...)
forint -> hex
conversions.Unfortunately, we have two different handling of "stream underflow" with
StreamWrapper
andByteStreamWriter
.Both of them might report their lengths, and both of them might happen to underflow or overflow.
PGStream
handlesStreamWrapper
as follows (see org.postgresql.core.PGStream#sendStream):PGStream
handlesByteStreamWriter
as follows (see org.postgresql.core.PGStream#send(ByteStreamWriter)):Note:
ByteStreamWriter
works in a push manner, so we can't easily stop it, so "throwing an error" on overflow might be ok.However, it is unfortunate we have different behaviours regarding "pad with zeros" vs "throw on underflow". I think we should raise an error on underflow in both cases.