Fix date_bin fn someways (like a cat?)

[workingjubilee]

This neither is used internally nor is it publicly available, due to invalid cfg attributes on it. Fixing the cfg on it breaks compilation, so the code inside it isn't valid either.

[eeeebbbbrrrr]

I'll take over this PR and do something different per the comment over there on line 124

[eeeebbbbrrrr]

haha. This should have been timestamp_bin and/or timestamptz_bin

per Discord chat, we can instead add a bin(stride, origin) function to those two types instead.

[eeeebbbbrrrr]

s/features/feature/g

😵‍💫 🌴

[nyurik]

note that cargo clippy catches these - another reason to add clippy to CI ;)

[workingjubilee]

No.

[workingjubilee]

Please examine our linting checks as they currently stand:

pgrx/.github/workflows/tests.yml

Lines 353 to 376 in 395c975

	- name: Run rustfmt
	run: cargo fmt --all -- --check
	- name: Run license check
	run: cargo install cargo-deny --force && ./ci/license-check.sh
	- name: Install cargo-pgrx
	run: cargo install --path cargo-pgrx/ --debug --force
	- name: Run 'cargo pgrx init' for ${{ matrix.version }}
	run: cargo pgrx init --pg$PG_VER download
	- name: Clippy -Awarnings
	run: cargo clippy -p pgrx --features pg$PG_VER -- -Awarnings
	- name: Clippy -Dwarnings sql-entity-graph
	run: cargo clippy -p pgrx-sql-entity-graph -- -Dwarnings
	- name: Check doc-links
	run: |
	cargo rustdoc -p pgrx --features pg$PG_VER -- \
	--document-private-items \
	-Drustdoc::broken-intra-doc-links \
	-Drustdoc::invalid-html-tags

[workingjubilee]

Nightly adds a lint that warns on this, and it's very annoying for building pgrx's code with nightly. Sorry, I need to go ahead and fix this.