Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Allow setting both assume role and web identity/role ARN #547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lfittl
Copy link
Member

@lfittl lfittl commented May 11, 2024

In a situation where both the web identity token file, role ARN, and assume role ARN are set, we now first retrieve credentials via web identity, and then assume the role specified as AWS_ASSUME_ROLE.

This helps with cross-account configurations on AWS in combination with the collector running in EKS.

TODO

  • Test that this works as expected
  • Think through whether there are any situations where this change is not desired (e.g. does AWS_ASSUME_ROLE get set by EKS automatically in some way?)

In a situation where both the web identity token file, role ARN, and
assume role ARN are set, we now first retrieve credentials via
web identity, and then assume the role specified as AWS_ASSUME_ROLE.

This helps with cross-account configurations on AWS in combination with
the collector running in EKS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant