Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for executing query at cursor position. #6841 #7380

Merged
merged 1 commit into from
May 27, 2024
Merged

Added support for executing query at cursor position. #6841 #7380

merged 1 commit into from
May 27, 2024

Conversation

anilsahoo20
Copy link
Contributor

No description provided.

@anilsahoo20
Copy link
Contributor Author

Pushed the code and the documentation is not updated as the execute query button icon need to be changed so the images need to be updated accordingly.

adityatoshniwal
adityatoshniwal requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@adityatoshniwal adityatoshniwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Got this error in console:
image
  • The pop up looks ugly. It has unnecessary padding:
image

  • None of the new preferences works realtime.

  • Don't ask again? is not working.

  • The dialog should have max-ht after which CodeMirror should scroll.

image

docs/en_US/preferences.rst Outdated Show resolved Hide resolved
docs/en_US/preferences.rst Outdated Show resolved Hide resolved
docs/en_US/query_tool.rst Outdated Show resolved Hide resolved
docs/en_US/query_tool_toolbar.rst Outdated Show resolved Hide resolved
web/pgadmin/static/js/Theme/standard.js Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSet.jsx Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx Outdated Show resolved Hide resolved
adityatoshniwal
adityatoshniwal requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@adityatoshniwal adityatoshniwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. remove padding
image
  1. I cannot select and copy the SQL from SQL Popup.
  2. Preferences real-time is not fixed.
  3. Console error is not fixed. Getting the same error.
  4. Warning dialog sometimes is not showing even if enabled.
  5. The editor size issue of dialog is not fixed.
  6. These preferences should be move to Options, not Editor:
image

web/pgadmin/tools/sqleditor/static/js/components/dialogs/ConfirmPromotionContent.jsx Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/MainToolBar.jsx Show resolved Hide resolved
web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py Show resolved Hide resolved
@anilsahoo20 anilsahoo20 force-pushed the GH-6841 branch 2 times, most recently from b5ca08d to 916a30f Compare May 27, 2024 05:04
@akshay-joshi akshay-joshi merged commit 6690b16 into pgadmin-org:master May 27, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatoshniwal adityatoshniwal adityatoshniwal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anilsahoo20 @adityatoshniwal @akshay-joshi