New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uasyncio.websocket.server: Allow the sending of binary WebSocket frames #43
Open
yannpom
wants to merge
2,412
commits into
pfalcon:master
Choose a base branch
from
yannpom:ws_binary
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already store that value in .co_flags. Meaning of individual bits may be different from CPython, but the purpose is the same. Proliferating and duplicating fields in codeobj creates more burden and confusion.
pfalcon
force-pushed
the
master
branch
17 times, most recently
from
January 23, 2021 09:33
b23dcb5
to
7f4f102
Compare
pfalcon
force-pushed
the
master
branch
3 times, most recently
from
January 24, 2021 13:49
d87cc03
to
8b11385
Compare
pfalcon
force-pushed
the
master
branch
3 times, most recently
from
February 1, 2021 13:31
9e56005
to
6f45126
Compare
pfalcon
force-pushed
the
master
branch
2 times, most recently
from
March 25, 2021 11:42
5a42161
to
5dd25bc
Compare
pfalcon
force-pushed
the
master
branch
2 times, most recently
from
April 10, 2021 05:07
4e6c1a6
to
d0d19af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I needed to send WebSocket binary frames and I had to change the hardcoded packet header to do so.
I'm not sure if you are interested in this commit. If so, fell free to merge.