Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature bits #51

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature bits #51

wants to merge 4 commits into from

Conversation

sarnold
Copy link

@sarnold sarnold commented Feb 1, 2021

These are basically the extra bits I needed to make an OS installer gui with strict input validation and a progress display. I think they should hopefully be useful enough for everyone; thanks.

* add next/prev button function
* add size params to DConfirmation Dialog class

Signed-off-by: Stephen Arnold <nerdboy@gentoo.org>
* this adds colors for valid/invalid text when .validate is True

Signed-off-by: Stephen Arnold <nerdboy@gentoo.org>
Signed-off-by: Stephen Arnold <nerdboy@gentoo.org>
…ere)

Signed-off-by: Stephen Arnold <nerdboy@gentoo.org>
@pfalcon
Copy link
Owner

pfalcon commented Feb 1, 2021

Thanks for sharing! I apologize in advance if it may take me quite some time to review these patches in detail. I also apologize in advance if I may find some changes here to be too adhoc and application-specific. Picotui is intended to provide common widgets useful in UIs, but not all possible widgets, nor all possible options for each widgets. Because these possibilities are infinite ;-). Instead, users are supposed to subclass existing widgets or write new to adjust their looks/behavior.

In this regard, this patchset is definitely a good example of what can be done for customization, and how to do that (even though it doesn't follow "subclass" approach).

@pfalcon pfalcon added the contrib label Feb 1, 2021
@sarnold
Copy link
Author

sarnold commented Feb 2, 2021

Don't worry, there is plenty of implementation fun left over, and it doesn't seem too bloaty (I say that, but my brain is a lot more like a geophysical black box 📉 (jello mold?) than it is like a class hierarchy). I did look at a boat-load of other progress "things" but I couldn't find another option that felt right. Thanks for taking the time to at least look at it.

@pfalcon
Copy link
Owner

pfalcon commented Apr 24, 2021

Btw, I'm planning to make some backwards-incompatible changes: #59. Feedback whether that should be 1.3/1.4 or 2.0 is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants