A big bundle of improvements. #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The entire exception chain will now be displayed (including suppressions). - Fixed a bunch of bugs in shrink stackframes that could cause incorrect displays. - De-coupled SourceLocators from the local file system. - Fixed a bug where null table keys caused a display issue. - Full stack trace message is now included in the debug screen (since it may get truncated on the left panel).
|
|
|
Nice, will have a look after work. |
|
It's a pretty massive change, so it would be fine to make it even more massive by including a fix for #5 too. |
|
Sounds good. There seems to be a weird little visual artifact above the code preview that only happens in Chrome. I'm going to take a look at that after work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of changes that I had applied to the debug screens in my own framework (https://github.com/lightning-framework/lightning/tree/master/src/main/java/lightning/debugscreen); these are pretty well tested.