Change Province Name To MultiLang Object

[amirzenoozi]

According To the Previous Talk, I think it's better if we had an object instead of a single string to show the province name in numberPlate

[ali-master]

May you write a few samples of what did you do? and Do you know what is the side-effects of this function in production for users who already have used this function?

[amirzenoozi]

@ali-master Actually it will be a really big change for users that use ProvinceName in their project, but I think it's better than prev format because in this change we can have multiple names for a single ProvinceCode but in the current version we have to have a single name for each ProvinceCode

i change this:

// Current plateInfo
{
  "type": "Car",
  "template": "PLATE_TEMPLATE",
  "province": "مرکزی",
  "category": "شخصی",
  "details": {
    "firstTwoDigits": "12",
    "nextThreeDigits": "145",
    "provinceCode": "47",
    "plateCharacter": "ب"
  }
}

to:

// New plateInfo
{
  "type": "Car",
  "template": "PLATE_TEMPLATE",
  "province": {
    "fa": "مرکزی", 
    "en": "Markazi",
  },
  "category": "شخصی",
  "details": {
    "firstTwoDigits": "12",
    "nextThreeDigits": "145",
    "provinceCode": "47",
    "plateCharacter": "ب"
  }
}

// New Format for More Than One Province
{
  "type": "Car",
  "template": "PLATE_TEMPLATE",
  "province": {
    "fa": ["تهران", "البرز"], 
    "en": ["Tehran", "Alborz"],
  },
  "category": "شخصی",
  "details": {
    "firstTwoDigits": "12",
    "nextThreeDigits": "145",
    "provinceCode": "21",
    "plateCharacter": "ب"
  }
}

if we want to remove the side-effects we have to keep province key with prev format and add a new key like provinceDetails to the final object, what do you think?

[ali-master]

it would be better if we prevent changing the current API and add new properties as well as you want.