Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat iranian postal code #340

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

amir-hossein-karimi
Copy link

feat: add iranian postal code validation function

@ghost
Copy link

ghost commented Sep 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@ali-master
Copy link
Member

Thanks for your contribution, we are reviewing

> this function validate entry postal code and return boolean for validation confirm

```js
import { iranianPostalCodeValidate } from "@persian-tools/persian-tools";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to validateIranianPostalCode


**Usage**

> this function validate entry postal code and return boolean for validation confirm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with This function validates the entry postal code and returns a boolean for validation confirmation.

/**
* iranianPostalCodeValidate
*
* @description Takes a postal code and validate with return a boolean.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add

@returns boolean

and explain the algorithms you've implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants