Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: review codes and try to clean and restrucure them #318

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ojvar
Copy link

@Ojvar Ojvar commented Apr 8, 2023

Review and cleaning codes
Try to restructure some files and using concentrated helpers and types

  • Create an error-handle
  • Create a type helper

@ghost
Copy link

ghost commented Apr 8, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Comment on lines +23 to +27
str = str
.replace(
/\{\{(عەرەبی|بە عەرەبی|بە ئویغوری)\|(.*?)ى(.*?)\}\}/g,
"{{$1|$2\u200b\u200b\u200bی\u200b\u200b\u200b$3}}",
)

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings starting with '{{{{عەرەبی|' and with many repetitions of '{{{{عەرەبی|a'.
This
regular expression
that depends on
library input
may run slow on strings starting with '{{{{عەرەبی|ى' and with many repetitions of 'ىa'.
@mediv0 mediv0 self-assigned this Jul 26, 2023
@mediv0 mediv0 added enhancement New feature or request Work in progress Process the issue and is not completed yet labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Work in progress Process the issue and is not completed yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants