Merge pull request #481 from sunanzhi/0.21.x

Fix missing required parameter in RunController:274
perftools · Jul 25, 2022 · 597eecc · 597eecc
2 parents 5b71f20 + f2cbb74
commit 597eecc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/Controller/RunController.php b/src/Controller/RunController.php
@@ -271,7 +271,7 @@ public function compare(Request $request): void
             'base_run' => $baseRun,
             'head_run' => $headRun,
             'candidates' => $candidates,
-            'url_params' => $request->get(),
+            'url_params' => $request->getQueryParams(),
             'comparison' => $comparison,
             'paging' => $paging,
             'search' => [

diff --git a/src/RequestProxy.php b/src/RequestProxy.php
@@ -17,6 +17,11 @@ public function __construct(Request $request)
         $this->request = $request;
     }
 
+    public function getQueryParams()
+    {
+        return $this->request->getQueryParams();
+    }
+
     public function get(string $key, $default = null)
     {
         return $this->request->getQueryParam($key, $default);

diff --git a/templates/runs/compare.twig b/templates/runs/compare.twig
@@ -36,7 +36,7 @@
     <div class="row-fluid row-spaced">
         <h3>Other runs with {{ base_run.meta.simple_url }}</h3>
         {% include 'runs/paginated-list.twig' with {runs: candidates.results, show_compare_link: true} %}
-        {{ helpers.pagination('run.compare', pagination, url_params) }}
+        {{ helpers.pagination('run.compare', paging, url_params) }}
     </div>
     {% endif %}