chore: bump up @apollo/server version to v4.9.3 [SECURITY] #471

renovate · 2023-08-30T22:44:36Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@apollo/server (source)	`4.6.0` -> `4.9.3`

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

GHSA-j5g3-5c8r-7qfx

Impact

What kind of vulnerability is it?

Apollo Server can log sensitive information (Studio API keys) if they are passed incorrectly (with leading/trailing whitespace) or if they have any characters that are invalid as part of a header value.

Who is impacted?

Users who (all of the below):

use either the schema reporting or usage reporting feature
use an Apollo Studio API key which has invalid header values
use the default fetcher (node-fetch) or configured their own node-fetch fetcher

The following node snippet can test whether your API key has invalid header values. This code is taken directly from node-fetch@2's header value validation code.

const invalidHeaderCharRegex = /[^\t\x20-\x7e\x80-\xff]/;
if (invalidHeaderCharRegex.test('<YOUR_API_KEY>')) {
  console.log('potentially affected');
}
console.log('unaffected');

If the provided API key is not a valid header value, whenever Apollo Server uses that API key in a request (to Studio, for example), node-fetch will throw an error which contains the header value. This error is logged in various ways depending on the user's configuration, but most likely the console or some configured logging service.

Patches

This problem is patched in the latest version of Apollo Server as soon as this advisory is published.

Workarounds

Try retrieving a new API key from Studio. Note: this may not work if the invalid character is not part of the secret (it may be derived from identifiers like graph name, user name).
Override the fetcher
Disable schema reporting and/or usage reporting

Solution

Apollo Server will now call .trim() on incoming API keys in order to eliminate leading/trailing whitespace and log a warning when it does so.
Apollo Server will now perform the same validation of API keys as node-fetch@2 performs on header values on startup. Apollo Server will throw an error on startup (i.e., fail to start completely) and notify the user their API key is invalid along with the offending characters.

Release Notes

apollographql/apollo-server (@apollo/server)

`v4.9.3`

Compare Source

Patch Changes

a1c725eaf Thanks @trevor-scheer! - Ensure API keys are valid header values on startup

Apollo Server previously performed no sanitization or validation of API keys on startup. In the case that an API key was provided which contained characters that are invalid as header values, Apollo Server could inadvertently log the API key in cleartext.

This only affected users who:
- Provide an API key with characters that are invalid as header values
- Use either schema or usage reporting
- Use the default fetcher provided by Apollo Server or configure their own node-fetch fetcher
Apollo Server now trims whitespace from API keys and validates that they are valid header values. If an invalid API key is provided, Apollo Server will throw an error on startup.

For more details, see the security advisory:
GHSA-j5g3-5c8r-7qfx

`v4.9.2`

Compare Source

Patch Changes

#7699 62e7d940d Thanks @trevor-scheer! - Fix error path attachment for list items

Previously, when errors occurred while resolving a list item, the trace builder would fail to place the error at the correct path and just default to the root node with a warning message:

Could not find node with path x.y.1, defaulting to put errors on root node.

This change places these errors at their correct paths and removes the log.

`v4.9.1`

Compare Source

Patch Changes

#7672 ebfde0007 Thanks @trevor-scheer! - Add missing nonce on script tag for non-embedded landing page

`v4.9.0`

Compare Source

Minor Changes

#7617 4ff81ca50 Thanks @trevor-scheer! - Introduce new ApolloServerPluginSubscriptionCallback plugin. This plugin implements the subscription callback protocol which is used by Apollo Router. This feature implements subscriptions over HTTP via a callback URL which Apollo Router registers with Apollo Server. This feature is currently in preview and is subject to change.

You can enable callback subscriptions like so:
```
import { ApolloServerPluginSubscriptionCallback } from '@&#8203;apollo/server/plugin/subscriptionCallback';
import { ApolloServer } from '@&#8203;apollo/server';

const server = new ApolloServer({
  // ...
  plugins: [ApolloServerPluginSubscriptionCallback()],
});
```
Note that there is currently no tracing or metrics mechanism in place for callback subscriptions. Additionally, this plugin "intercepts" callback subscription requests and bypasses some of Apollo Server's internals. The result of this is that certain plugin hooks (notably executionDidStart and willResolveField) will not be called when handling callback subscription requests or when sending subscription events.

For more information on the subscription callback protocol, visit the docs:
https://www.apollographql.com/docs/router/executing-operations/subscription-callback-protocol/

Patch Changes

#7659 4784f46fb Thanks @renovate! - Update graphql-http dependency

`v4.8.1`

Compare Source

Patch Changes

#7636 42fc65cb2 Thanks @trevor-scheer! - Update test suite for compatibility with Node v20

`v4.8.0`

Compare Source

Minor Changes

#7634 f8a8ea08f Thanks @dfperry5! - Updating the ApolloServer constructor to take in a stringifyResult function that will allow a consumer to pass in a function that formats the result of an http query.

Usage:
```
const server = new ApolloServer({
  typeDefs,
  resolvers,
  stringifyResult: (value: FormattedExecutionResult) => {
    return JSON.stringify(value, null, 2);
  },
});
```

`v4.7.5`

Compare Source

Patch Changes

#7614 4fadf3ddc Thanks @Cellule! - Publish TypeScript typings for CommonJS modules output.

This allows TypeScript projects that use CommonJS modules with
moduleResolution: "node16" or
moduleResolution: "nodeNext"
to correctly resolves the typings of apollo's packages as CommonJS instead of ESM.
Updated dependencies [4fadf3ddc]:
- @apollo/cache-control-types @1.0.3
- @apollo/server-gateway-interface @1.1.1
- @apollo/usage-reporting-protobuf @4.1.1

`v4.7.4`

Compare Source

Patch Changes

0adaf80d1 Thanks @trevor-scheer! - Address Content Security Policy issues

The previous implementation of CSP nonces within the landing pages did not take full advantage of the security benefit of using them. Nonces should only be used once per request, whereas Apollo Server was generating one nonce and reusing it for the lifetime of the instance. The reuse of nonces degrades the security benefit of using them but does not pose a security risk on its own. The CSP provides a defense-in-depth measure against a potential XSS, so in the absence of a known XSS vulnerability there is likely no risk to the user.

The mentioned fix also coincidentally addresses an issue with using crypto functions on startup within Cloudflare Workers. Crypto functions are now called during requests only, which resolves the error that Cloudflare Workers were facing. A recent change introduced a precomputedNonce configuration option to mitigate this issue, but it was an incorrect approach given the nature of CSP nonces. This configuration option is now deprecated and should not be used for any reason since it suffers from the previously mentioned issue of reusing nonces.

Additionally, this change adds other applicable CSPs for the scripts, styles, images, manifest, and iframes that the landing pages load.

A final consequence of this change is an extension of the renderLandingPage plugin hook. This hook can now return an object with an html property which returns a Promise<string> in addition to a string (which was the only option before).

`v4.7.3`

Compare Source

Patch Changes

#7601 75b668d9e Thanks @trevor-scheer! - Provide a new configuration option for landing page plugins precomputedNonce which allows users to provide a nonce and avoid calling into uuid functions on startup. This is useful for Cloudflare Workers where random number generation is not available on startup (only during requests). Unless you are using Cloudflare Workers, you can ignore this change.

The example below assumes you've provided a PRECOMPUTED_NONCE variable in your wrangler.toml file.

Example usage:
```
const server = new ApolloServer({
  // ...
  plugins: [
    ApolloServerPluginLandingPageLocalDefault({
      precomputedNonce: PRECOMPUTED_NONCE,
    }),
  ],
});
```

`v4.7.2`

Compare Source

Patch Changes

#7599 c3f04d050 Thanks @trevor-scheer! - Update @apollo/utils.usagereporting dependency. Previously, installing @apollo/gateway and @apollo/server could result in duplicate / differently versioned installs of @apollo/usage-reporting-protobuf. This is because the @apollo/server-gateway-interface package was updated to use the latest protobuf, but the @apollo/utils.usagereporting package was not. After this change, users should always end up with a single install of the protobuf package when installing both @apollo/server and @apollo/gateway latest versions.

`v4.7.1`

Compare Source

Patch Changes

#7539 5d3c45be9 Thanks @mayakoneval! - 🐛 Bug Fix for Apollo Server Landing Pages on Safari. A Content Security Policy was added to our landing page html so that Safari can run the inline scripts we use to call the Embedded Sandbox & Explorer.

`v4.7.0`

Compare Source

Minor Changes

#7504 22a5be934 Thanks @mayakoneval! - In the Apollo Server Landing Page Local config, you can now opt out of the telemetry that Apollo Studio runs in the
embedded Sandbox & Explorer landing pages. This telemetry includes Google Analytics for event tracking and
Sentry for error tracking.

Example of the new config option:

const server = new ApolloServer({
  typeDefs,
  resolvers,
  plugins: [
    process.env.NODE_ENV === 'production'
      ? ApolloServerPluginLandingPageProductionDefault({
          graphRef: 'my-graph-id@my-graph-variant',
          embed: {
            runTelemetry: false
          },
        })
      : ApolloServerPluginLandingPageLocalDefault({
          embed: {
            runTelemetry: false
          },
        }),
  ],
});

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

perfsee · 2023-08-30T22:48:23Z

perfsee

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                       main …vulnerability                 +/- ##
===================================================================
= Bundle               3.1 MB         3.1 MB                       
= Initial JS          1.12 MB        1.12 MB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   76             76                       
= Chunks                   75             75                       
= Packages                 79             79                       
= Duplicates                0              0

codecov · 2023-08-30T22:59:46Z

Codecov Report

Merging #471 (8b4d6f0) into main (b780532) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   79.79%   79.69%   -0.10%     
==========================================
  Files         403      403              
  Lines       37183    37183              
  Branches     2306     2301       -5     
==========================================
- Hits        29670    29633      -37     
- Misses       7312     7350      +38     
+ Partials      201      200       -1

see 6 files with indirect coverage changes

chore: bump up @apollo/server version to v4.9.3 [SECURITY]

8b4d6f0

renovate bot added the dependencies label Aug 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump up @apollo/server version to v4.9.3 [SECURITY] #471

chore: bump up @apollo/server version to v4.9.3 [SECURITY] #471

renovate bot commented Aug 30, 2023 •

edited

perfsee bot commented Aug 30, 2023

codecov bot commented Aug 30, 2023

chore: bump up @apollo/server version to v4.9.3 [SECURITY] #471

Are you sure you want to change the base?

chore: bump up @apollo/server version to v4.9.3 [SECURITY] #471

Conversation

renovate bot commented Aug 30, 2023 • edited

GitHub Vulnerability Alerts

Impact

What kind of vulnerability is it?

Who is impacted?

Patches

Workarounds

Solution

Release Notes

Patch Changes

Patch Changes

Patch Changes

Minor Changes

Patch Changes

Patch Changes

Minor Changes

Patch Changes

Patch Changes

Patch Changes

Patch Changes

Patch Changes

Minor Changes

Configuration

perfsee bot commented Aug 30, 2023

perfsee

codecov bot commented Aug 30, 2023

Codecov Report

renovate bot commented Aug 30, 2023 •

edited