Add guitar tuner #976
Draft
Add guitar tuner #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original image is from pixabay: https://pixabay.com/de/photos/gitarre-musik-klang-saiten-6118096/
twollgam
force-pushed
the
AddGuitarTuner
branch
from
fac0b29
to
59ed6ec
Compare
|
Download the artifacts for this pull request:
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time. |
|
I think this is still a draft and doesn't need review yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pr adds a guitar tuner screen to performous. It is an alpha feature that must be enabled in the configuration.
It has two objectives:
Closes Issue(s)
None.
Motivation
I like to add real guitars as instruments and this is a very basic start.
More
Nothing yet.
Additional Notes
It seems that my impression that deep notes are not exactly detected will be proved. Currently all strings are detected right but the deep e string is not.