Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rows in the dataframe; not showing up on the map #24

Open
perfectly-preserved-pie opened this issue Jan 29, 2023 · 3 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@perfectly-preserved-pie
Copy link
Owner

perfectly-preserved-pie commented Jan 29, 2023

Some of the rows aren't getting rendered on the map. Why?

INFO:root:The original dataframe has 1296 rows. There are 1208 rows in the filtered dataframe. There are 1208 markers on the map.

That's ~90 rows missing, even with all options/checked. There shouldn't be any actual filtering going on.

@perfectly-preserved-pie perfectly-preserved-pie added the bug Something isn't working label Jan 29, 2023
@perfectly-preserved-pie
Copy link
Owner Author

perfectly-preserved-pie commented Mar 13, 2023

missing_rows.csv
Using e342270 I was able to generate a CSV containing the missing rows.

The only thing every missing row has in common is a malformed popup_html cell. Why?

@perfectly-preserved-pie
Copy link
Owner Author

perfectly-preserved-pie commented Mar 16, 2023

(maybe related) I'm missing some subtypes and rental terms:

>>> df.subtype.unique()
array(['CONDO', 'APT', 'SFR/D', 'SFR/A', 'STUD/A', 'SFR', 'APT/A',
       'MANL/D', 'TPLX/A', 'QUAD/A', 'CONDO/A', 'APT/D', 'DPLX/A',
       'TPLX/D', 'TWNHS/A', 'TWNHS', nan, 'DPLX/D', 'CONDO/D', 'STUD/D',
       'QUAD/D', 'TWNHS/D', 'RMRT/A', 'CABIN/D', 'RMRT/D'], dtype=object)

I def don't have CABIN/D, RMRT/D, or STUD/D defined in Dash.

>>> df.Terms.unique()
<StringArray>
['12M', 'NG', <NA>, '6M', 'MO', '24M', 'STL']
Length: 7, dtype: string

NA, 6M, and STL aren't defined in Dash either.

f6d1404 and 410703f resolve the missing terms. Will look into the missing subtypes later.

@perfectly-preserved-pie
Copy link
Owner Author

689f96d fixes the subtype bug. We're close to displaying the whole dataframe now:

The resulting filtered dataframe has 1950 rows and 1950 markers out of 1965 total rows.

Still 15 rows missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant