This repository has been archived by the owner on Aug 25, 2020. It is now read-only.
Fix vulnerabilities #142
Merged
Fix vulnerabilities #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze-flo
reviewed
Mar 18, 2020
package.json
Outdated
| "sinon": "7.2.7", | ||
| "sinon-chai": "3.3.0" | ||
| } | ||
| "name": "sashay", |
There was a problem hiding this comment.
Looks like prettier changed the indent to 4. Could that have unintended consequences?
There was a problem hiding this comment.
It shouldn't but reverted just in case ;)
added 2 commits
March 18, 2020 12:12
narehart
force-pushed
the
fix-vulnerabilities
branch
from
c509385
to
6f0ab9f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimist
mkdirp
Upgrade to latest version which uses
minimistwith vulnerability fix.mocha
Upgrade to latest version which uses
minimistwith vulnerability fix. Tested.karma-mocha
Using an exact version of
minimist. Fixed using npm resolution. Tested.Will remove when this PR is merged:
karma-runner/karma-mocha#212
karma
Uses
optimistwhich uses an outdated version ofminimist. Fixed using npm resolution. Tested.No open issues or PRs on Github.
handlebars
Uses
optimistwhich uses an outdated version ofminimist. Fixed using npm resolution. Tested.Will remove when this issue is resolved:
handlebars-lang/handlebars.js#1658
acorn
enzyme
Uses
cheeriowhich uses an outdated version ofjsdomwhich usesacorn. Fixed using npm resolution. Tested.eslint
Reinstall to pull updated
acorndependency.