Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auction: credit VCB when ending an auction #4394

Merged
merged 9 commits into from
May 21, 2024

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented May 15, 2024

Describe your changes

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    This is consensus-breaking and state-breaking. Migration WIP.

@erwanor erwanor added C-bug Category: a bug consensus-breaking breaking change to execution of on-chain data state-breaking breaking change to on-chain data migration A pull request that contains a migration A-auction Area: Relates to the auction component labels May 15, 2024
@erwanor erwanor marked this pull request as ready for review May 20, 2024 22:18
@erwanor erwanor force-pushed the erwan/auction_vcb_close_by_user branch from a0b21ed to 24210b4 Compare May 20, 2024 22:18
@erwanor erwanor added this to the Sprint 7 milestone May 20, 2024
@erwanor erwanor requested a review from TalDerei May 20, 2024 22:19
@erwanor
Copy link
Member Author

erwanor commented May 21, 2024

I have tested this in two ways:

  • a local devnet running v0.75.0 with a collection of auctions running every block
  • an application test that reproduce the bug (and attests that the fix works).

Additionally, I ran the migration on a fork of the running testnet to observe if any deviations were recorded, but without resuming. I didn't see any deviations, that is to say the tallied auction VCB and the one onchain were equal.

@erwanor erwanor requested review from hdevalence and zbuc May 21, 2024 17:06
@erwanor
Copy link
Member Author

erwanor commented May 21, 2024

This is generating conflicts to every other U1 migrations and has received a lot of offline attention so merging this optimistically, but async reviews are welcome.

@erwanor erwanor merged commit d86080b into main May 21, 2024
13 checks passed
@erwanor erwanor deleted the erwan/auction_vcb_close_by_user branch May 21, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-auction Area: Relates to the auction component C-bug Category: a bug consensus-breaking breaking change to execution of on-chain data migration A pull request that contains a migration state-breaking breaking change to on-chain data
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants