pcli: auction end-all, withdraw-all #4385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't work because there's not a way to track the "local" state of the auction NFT, which may lag the on-chain state. So once a GDA is completed, close-all doesn't work (because all the auctions are believed to be closed), but withdraw-all doesn't work (because the auction NFTs are not closed) |
|
Suggestion: add a |
erwanor
added
A-client
1 task
hdevalence
pushed a commit
that referenced
this pull request
May 24, 2024
#4472) ## Describe your changes This PR makes two changes: 1. Add an `auction_ids_filter` to `AuctionsRequest`, so that clients can make requests (e.g., with `queryLatestState`) for just specific auctions rather than all auctions at once. 2. Add a `local_seq` property to `AuctionsResponse` to indicate the local view service's own knowledge of the sequence number for an auction. (See #4385 (comment).) Relevant changes are to the protobuf [here](https://github.com/penumbra-zone/penumbra/pull/4472/files#diff-03b7341d5bf81ab9c8d8542d220d5ba4ae122bd3837531309742b685d7ec1619), plus a couple TODO items [here](https://github.com/penumbra-zone/penumbra/pull/4472/files#diff-9f4ca4cefeac93c9275a2f9d962d6670f6ab1c1381fd3d7c806f9316e3779ccbR986) and [here](https://github.com/penumbra-zone/penumbra/pull/4472/files#diff-36188e6ab5083e8be9d29039370cc523cfcfede683b223327b2d90e3f75d40c7R461). ## Issue ticket number and link penumbra-zone/web#1059 and #4385 (comment) ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > Only touches Auctions RPC methods.
erwanor
force-pushed
the
pcli-auction-ux-tweaks
branch
from
b0a9c4d
to
77e0fb0
Compare
erwanor
approved these changes
May 28, 2024
cratelyn
reviewed
May 28, 2024
Signed-off-by: Erwan Or <erwan.ounn.84@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changes the
pcli tx auctioncommands to support "end all", "withdraw all" rather than requiring specific auction IDsChecklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: