feat: support display seed phrase discreetly #3501
Open
+77
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erwanor @hdevalence GM sir, could you please help me to review this pr😀 |
|
@erwanor Hi sir, could you please help me to review this pr😀 |
|
Hey @Halimao, sorry this took so long but I am going to review this in the next couple days, possibly amending the branch before merging this in. Thanks for taking a stab at this! |
Signed-off-by: Halimao <1065621723@qq.com>
Signed-off-by: Halimao <1065621723@qq.com>
Hi sir, could u please help me review this PR then? |
Signed-off-by: Halimao <1065621723@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
pcli init soft-kms generatewill print a seed phrase in the terminal, this is dangerous.This pr added a new option
--display-discreetlyto support displaying seed phrases discreetly on an alternate screen.