Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern objects can leak if not deepcloned #176

Open
laras126 opened this issue Apr 8, 2020 · 0 comments
Open

Pattern objects can leak if not deepcloned #176

laras126 opened this issue Apr 8, 2020 · 0 comments
Labels
bug Something isn't working standards A standard is needed to resolve this issue.

Comments

@laras126
Copy link
Contributor

laras126 commented Apr 8, 2020

At the moment, when a pattern's object is imported, it must be deep cloned in order to prevent changes leaking into other instances of the pattern. Sometimes developers neglect to do this, and the consequences are very hard to debug and track down.

The pattern objects should be cloned as they are imported - one way to do this would be to export classes instead of objects.

@laras126 laras126 added the bug Something isn't working label Apr 8, 2020
@laras126 laras126 added the standards A standard is needed to resolve this issue. label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working standards A standard is needed to resolve this issue.
Projects
None yet
Development

No branches or pull requests

1 participant