Canonical list of standards to reference

[laras126]

There is a growing list of established coding standards for working with Larva tools that should worked into our pipeline in some way. In the mean time, these should live in an accessible place for tech leads to reference so these items can be caught in code reviews.

Where should these live?

Some examples of the standards / stylistic guidelines so far:

• Where to write CSS
  • CSS classes in Twig is the best option
  • Only write CSS classes in prototype JS if they need to be removed in variants, or are from a shared pattern
• Modules should not include modules
• Pattern JS:
  • Disallow string and array manipulation e.g. .replace
  • All instances of imported patterns should be cloned - see Pattern objects can leak if not deepcloned #176