Patch for http-overflow and more switches in @http #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryCordewener
commented
Sep 20, 2022
HarryCordewener
commented
Sep 21, 2022
src/bsd.c
Outdated
| @@ -1202,6 +1187,7 @@ handle_curl_msg(CURLMsg *msg) | |||
| } | |||
| } | |||
| if (resp->too_big) { | |||
| pe_regs_set_int(resp->pe_regs, PE_REGS_Q, "http-overflow", 1); | |||
There was a problem hiding this comment.
Should I just set this into %1?
Right now, this is being set into a q-register (and 0 never being set on success, which is bad, as it can cause false-positives) because status & content-type are being set into q-regs on completion. And changing those would be a breaking change.
There was a problem hiding this comment.
Input still needed on this @talvo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight refactoring of the HTTP code in
bsd.cand adding features to@httpincmds.c.Added: