1350: BUGFIX - Allow ansi code translation for json unescape. #1351

HarryCordewener · 2021-02-25T22:36:14Z

This is related to the following ticket: #1350

src/notify.c

src/funjson.c

src/conf.c

src/funjson.c

src/notify.c

HarryCordewener · 2021-03-25T20:25:50Z

Ready for re-review.

hdrs/ansi.h

src/funjson.c

CHANGES.188.md

talvo · 2021-03-25T23:24:47Z

src/funjson.c

@@ -64,6 +65,27 @@ json_escape_string(char *input)
  return buff;
 }

+/** Unescape a string for use as a JSON string. Returns a calloced buffer under 'json.string.partialbuf'. **/


Needs a proper comment header documenting args and return values, and a more detailed/accurate description of what it's doing would be good - "unescape" isn't really descriptive of what it's doing

New comment header description added. Let me know if the description works as is.

src/funjson.c

HarryCordewener · 2021-06-28T19:21:01Z

There's an error in here somewhere causing a one-off error with \0 in json_map for the value, as it puts the null too far to the right.

Debug:
https://pastebin.com/FgTANMJE

Edit: Fix being tested in production.

HarryCordewener · 2021-09-24T01:39:13Z

This has been in production for a few months now. But I gotta figure out what is going on with the unit test's test harness.

HarryCordewener · 2022-05-24T01:54:48Z

Tests fixed. Ready for a new look @talvo

Liminality and others added 8 commits February 25, 2021 23:35

1350: Allow ansi code translation for json unescape.

03a8d25

Issue 1350: Add to CHANGES file.

614e170

1350: Add a test to cover not getting ? characters from ansi unescape.

754d49c

1350: PR Request - Use escape character definition from ansi.h

fdd47d3

Working Prototype

736abaa

Make use of the json_unescape_latin1string function

d9de9e8

Make the config option functional.

09e2be9

Add a test for markupstring

41a7c4f

HarryCordewener commented Mar 25, 2021

View reviewed changes

src/notify.c Outdated Show resolved Hide resolved