Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile for build #1314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nrawling
Copy link

Pretty straightforward Dockerfile. I picked Debian because it is pretty lightweight compared to other distros, but not prone to libc challenges like Alpine. I managed most dependencies except icu-config, which now appears to be deprecated.

A multi-stage build that does user configuration, etc. is certainly possible. However, I don't know if it is worthwhile to remove the build infrastructure, which isn't terribly large as it is. I think a lot could be done with using environment variables to configure external state for DB, etc.

It is failing two tests:

Running tests for json:
TEST FAILURE: json.string.5
command: think json(string, accent(foo, f:o))
result: "foo"
pattern: ^"f\u00F6o"

TEST FAILURE: json.string.6
command: think json_query(json(string,accent(foo,f:o)), unescape)
result: foo
pattern: ^f\xF6o

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

81 tests, 79 succeeded, 2 failed (0 expected failures)
failed tests:
json.string.5, json.string.6

@nrawling
Copy link
Author

This PR begins work on #1304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant