fix(headless): Do not create an empty session in app context on logout #3800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting Pull Requests
General
Examples:
"fix(google): Fixed foobar bug"
,"feat(accounts): Added foobar feature"
.ChangeLog.rst
.AUTHORS
.Description
This commit complements #3785 . Even though the headless API won't attach a session token when user logs out, the empty session is still created in the database upon exiting the context manager
authentication_context()
. This patch fixes this by also checking if the session is empty within the context manager.Note: this behavior is quite tricky to test, because normally there is no way to access the 'ghost' session. If the session backend is guaranteed to be database-backed, then one way is to check the number of sessions before and after logout. The test code may be slightly messy though - I'll add a test if requested.