Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(headless): Do not create an empty session on logout #3785

Merged
merged 1 commit into from May 12, 2024
Merged

fix(headless): Do not create an empty session on logout #3785

merged 1 commit into from May 12, 2024

Conversation

joonhyungshin
Copy link
Contributor

Submitting Pull Requests

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

Description

Fixes #3784 .

@coveralls
Copy link

Coverage Status

coverage: 95.575% (+0.007%) from 95.568%
when pulling 96a9ab7 on joonhyungshin:fix-headless-logout
into 38021ae on pennersr:main.

@pennersr pennersr merged commit 35db948 into pennersr:main May 12, 2024
58 checks passed
@joonhyungshin joonhyungshin deleted the fix-headless-logout branch May 13, 2024 00:23
@joonhyungshin joonhyungshin mentioned this pull request May 13, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headless SessionView for APP client creates an unnecessary session
3 participants
@joonhyungshin @coveralls @pennersr