WIP: Reference dockerfile #80
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain the rationale behind the dockerfile being built from such a minimal base
brayniac
reviewed
Feb 16, 2023
|
This seems like a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on this comment: #72 (comment) I decided to write a Dockerfile from a minimal Debian install that demonstrates building and running the app, as a form of executable documentation for the steps required to build Pelikan.
We can either keep this around as a reference, integrate it into CI so the build breaks if we add new implicit dependencies that aren't accounted for, or extract the list of packages required into some other form of non-executable documentation