-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use full path for images to avoid rst2pdf 'Missing image file' error #7
Use full path for images to avoid rst2pdf 'Missing image file' error #7
Conversation
1d5dd7a
to
3768206
Compare
@justinmayer can you help me to understand why |
I see the following:
I imagine the problem is that Python 3.6 is no longer supported, but I can't say for certain. I think the best course of action is to remove Python 3.6 from the test matrix and see whether the problem persists. |
I dropped Python 3.6 from the test matrix via 5f26b2b, which seems to have resolved that particular problem. |
@wombelix: I have fixed multiple issues, which I believe will address the errors seen here in your PR. Can you rebase this branch on |
3768206
to
39f1382
Compare
Thanks a lot, looks better but still one error in the pre-commit.ci:
|
That pre-commit.ci problem seems to be because the Flake8 project moved from GitLab to GitHub. We can safely ignore that error. Side note: I am increasingly unconvinced that pre-commit.ci provides enough value and may decide to remove it entirely. As for Flake8, I am displeased with how that project is managed, and I would never use it again for any new projects. I may replace it across-the-board with Ruff. |
@wombelix: I resolved the CI issues in this PR. Could you please add a Release type: patch
Use full path for images to avoid rst2pdf 'Missing image file' error |
@wombelix: Never mind — I took care of adding the |
Images added in a Post / Page will not be added to the PDF, rst2pdf can't find the image due to the relative path and will raise a
Missing image file
error. The PDF will be generated, but without the image, a red cross is added instead.Can be resolved by searching for images and replace
{.*}
(e.g.{static}
) with the path to Pelican,~/pelican/content
in the following Example.before:
..image:: {static}/images/picture.jpg
after:
..image:: ~/pelican/content/images/picture.jpg
This PR supports reStructuredText and Markdown.