import all potentially useful fields from CSV in to model #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That said I really like the idea of adding all this data and we should do it. However it might make sense to do it as part of a specific feature rather than in anticipation of some other PR using it. |
Joxit
added a commit
that referenced
this pull request
Jan 20, 2021
missinglink
pushed a commit
that referenced
this pull request
Jan 21, 2021
* feat(import): add support for openaddresses geojsons format * feat(import): map field used in #402 * chore(import): apply changes from code review
|
This branch has some simple conflicts compared to master. Also should the default name also be modified to include the unit? .setName( 'default', (record.NUMBER + ' ' + record.STREET) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imports some fields which are present in the CSV file but are not currently available on the model.
after I pushed this PR I realised that #320 covers some of the same territory.
additional fields imported:
The metadata properties are useful downstream as 'hints' for the admin lookup service, this is particularly true in Australia where the CITY field in OA is better than the PIP locality.
I updated the tests and added a few more because the coverage wasn't great.