Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated version tag from compose files #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arnesetzer
Copy link

馃憢 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change 馃殌

With docker compose version v2.26 (some threads on github say since v2.25, but I didn't test that) compose throws a warning if the compose file still has a version tag.
WARN[0000] /home/geo-coder/docker/projects/[PROJECT NAME]/docker-compose.yml: 'version' is obsolete (https://docs.docker.com/compose/compose-file/04-version-and-name/)


Here's what actually got changed 馃憦

  • Remove all version tags from existing docker-compose.yml files

Here's how others can test the changes 馃憖

  • Clone the repo move to a project and check if the warning comes up.

@arnesetzer arnesetzer changed the title Remove version tag from compose files Remove deprecated version tag from compose files Apr 12, 2024
@missinglink
Copy link
Member

missinglink commented Apr 12, 2024

Interesting, thanks.

So removing this would be a breaking change for older versions, do you know which versions?

For now I'd prefer displaying a warning on newer versions over a breaking change for older versions.

@arnesetzer
Copy link
Author

According to some issues on the docker cli it is deprecated since the jump from docker compose v1 to compose v2.
(docker/compose#8950)

I agree with you that this on very low priority. We can leave that as a draft until docker compose will throw an error if the version tag is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants