Fix example JSON parser null issue #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch, but I'd like to resolve this properly in 0.8.0 by redesigning the error reporting system to allow |
dmajda
added a commit
that referenced
this pull request
Aug 20, 2013
We couldn't return |null| in the |value| rule of the JSON example parser because that would mean parse failure. So until now, we just returned |"null"| (a string). This was obviously stupid, so this commit changes the |value| rule to return a special object instead that is converted to |null| later. Based on patches by Patrick Logan (GH-91) and Jakub Vrána (GH-191).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just implemented your advice from #17
Only tested in the online version, everything appears to be working.