meta: Add support for id3v2 CHAP and CTOC frames #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommoa
force-pushed
the
add-id3v2-chap-ctoc
branch
from
b45f588
to
6db6e6f
Compare
These were standardised in https://id3.org/id3v2-chapters-1.0. Something I initially considered (and did) was to use `Cue`s and `CuePoint`s instead of creating new types, but decided against it because: - `Cue` is tied to the format, whereas these are tied to the metadata. - According to the spec, chapters can overlap, and so must have a duration. - It is unclear to me what the index should be. - `CuePoint`s cannot have another `CuePoint` within them, which may be an issue for multi-level tables of content. - Chapters and tables of contents would end up mixed as `Cue`s despite being different types. Resolves: pdeljanov#16
Tommoa
force-pushed
the
add-id3v2-chap-ctoc
branch
from
6db6e6f
to
07bb537
Compare
These are also supported by the id3v2 specification, and so should be supported.
|
Hi @Tommoa, Thank you for implementing this! I think you touch on a larger point that cues/chapters should be part of the metadata and not the format. I generally agree with this line of thinking. It's also basically why I avoided this issue for the time being. I'd like to use your code, but I also think those larger API issues should be addressed first. After the v0.5.2 release I hope to get started on v0.6 where we can start making breaking API changes. Hopefully we can land on something good. Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were standardised in https://id3.org/id3v2-chapters-1.0.
Something I initially considered (and did) was to use
Cues andCuePoints instead of creating new types, but decided against it because:Cueis tied to the format, whereas these are tied to the metadata.CuePoints cannot have anotherCuePointwithin them, which may be an issue for multi-level tables of content.Cues despite being different types.Resolves: #16