Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_id3v2 cannot read chapter markers from file #16

Open
rtyler opened this issue Sep 22, 2020 · 3 comments · May be fixed by #157
Open

read_id3v2 cannot read chapter markers from file #16

rtyler opened this issue Sep 22, 2020 · 3 comments · May be fixed by #157

Comments

@rtyler
Copy link

rtyler commented Sep 22, 2020

I could have missed where this data might show up, but taking some sample podcasts from Mac Power Users. (e.g. https://www.podtrac.com/pts/redirect.mp3/traffic.libsyn.com/secure/relaympu/mpu554.mp3)

Dumping out tags from the Metadata gives me this

k: TALB, v: Mac Power Users
k: TPE1, v: Mac Power Users
k: TIT2, v: 554: Read-it-later Services
k: COMM!eng, v: Read-it-later services can be a great way to save and enjoy an article later, away from the noise of social media or an overflowing RSS client. This week, David and Stephen talk about some of the popular choices, and how to keep them from becoming just another thing to check. T
hen, a recap of Apple’s recent media event.
k: USLT!eng, v: Read-it-later services can be a great way to save and enjoy an article later, away from the noise of social media or an overflowing RSS client. This week, David and Stephen talk about some of the popular choices, and how to keep them from becoming just another thing to check. T
hen, a recap of Apple’s recent media event.
k: TLEN, v: 5997000
k: TYER, v: 2020
k: TENC, v: Forecast

Whereas ffprobe on the same file will output:

Input #0, mp3, from 'mpu554.mp3':
  Metadata:
    album           : Mac Power Users
    artist          : Mac Power Users
    title           : 554: Read-it-later Services
    comment         : Read-it-later services can be a great way to save and enjoy an article later, away from the noise of social media or an overflowing RSS client. This week, David and Stephen talk about some of the popular choices, and how to keep them from becoming just an
    lyrics-eng      : Read-it-later services can be a great way to save and enjoy an article later, away from the noise of social media or an overflowing RSS client. This week, David and Stephen talk about some of the popular choices, and how to keep them from becoming just an
    TLEN            : 5997000
    encoded_by      : Forecast
    date            : 2020
  Duration: 01:39:57.11, start: 0.000000, bitrate: 128 kb/s
    Chapter #0:0: start 0.000000, end 466.287000
    Metadata:
      title           : MPU 554
    Chapter #0:1: start 466.287000, end 964.340000
    Metadata:
      title           : Read-it-Later Services?
    Chapter #0:2: start 964.340000, end 1597.615000
    Metadata:
      title           : Safari Reading List
    Chapter #0:3: start 1597.615000, end 3042.409000
    Metadata:
      title           : Third-Party Services
    Chapter #0:4: start 3042.409000, end 3345.281000
    Metadata:
      title           : What We’re Using
    Chapter #0:5: start 3345.281000, end 4158.417000
    Metadata:
      title           : David’s Research Workflow
    Chapter #0:6: start 4158.417000, end 5997.000000
    Metadata:
      title           : Apple’s September
    Stream #0:0: Audio: mp3, 44100 Hz, stereo, fltp, 128 kb/s
    Stream #0:1: Video: mjpeg (Baseline), yuvj444p(pc, bt470bg/unknown/unknown), 1400x1400, 90k tbr, 90k tbn, 90k tbc (attached pic)
    Metadata:
      comment         : Cover (front)
@pdeljanov
Copy link
Owner

Hey @rtyler,

You're not mistaken. Chapters are an extension to the original ID3v2 standards, and they haven't been implemented yet.

This is something we'll want to support, but it may take some time since I'm currently focused on implementing M4A/MP4 support.

@SeanOMik
Copy link

SeanOMik commented Jan 6, 2022

Was this ever implemented?

@pdeljanov
Copy link
Owner

Hi @SeanOMik, sorry, this hasn't been fixed yet. It's a bit tedious to fix so it's been low priority. I'll probably loop back around to it after v0.5 is published.

Tommoa added a commit to Tommoa/symphonia that referenced this issue Oct 8, 2022
@Tommoa
meta: Add support for id3v2 CHAP and CTOC frames
6db6e6f 
These were standardised in https://id3.org/id3v2-chapters-1.0.

Something I initially considered (and did) was to use `Cue`s and
`CuePoint`s instead of creating new types, but decided against it
because:

- `Cue` is tied to the format, whereas these are tied to the metadata.
- According to the spec, chapters can overlap, and so must have a
  duration.
- It is unclear to me what the index should be.
- `CuePoint`s cannot have another `CuePoint` within them, which may be
  an issue for multi-level tables of content.
- Chapters and tables of contents would end up mixed as `Cue`s despite
  being different types.

Resolves: pdeljanov#16
@Tommoa Tommoa linked a pull request Oct 8, 2022 that will close this issue
Open
Tommoa added a commit to Tommoa/symphonia that referenced this issue Oct 10, 2022
@Tommoa
meta: Add support for id3v2 CHAP and CTOC frames
07bb537 
These were standardised in https://id3.org/id3v2-chapters-1.0.

Something I initially considered (and did) was to use `Cue`s and
`CuePoint`s instead of creating new types, but decided against it
because:

- `Cue` is tied to the format, whereas these are tied to the metadata.
- According to the spec, chapters can overlap, and so must have a
  duration.
- It is unclear to me what the index should be.
- `CuePoint`s cannot have another `CuePoint` within them, which may be
  an issue for multi-level tables of content.
- Chapters and tables of contents would end up mixed as `Cue`s despite
  being different types.

Resolves: pdeljanov#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

meta: Add support for id3v2 CHAP and CTOC frames Tommoa/symphonia
3 participants
@rtyler @pdeljanov @SeanOMik