loosen residual test tolerance slightly #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest version of
glmmTMBis about to go to CRAN. We changed the parameterization of the Gaussian dispersion from log(variance) to log(SD), which changes results slightly and made one of your comparisons testing withglmmTMBfail (the deviations were only 3e-08 on average, but this is larger than the defaultexpect_equal()tolerance of ~ 1.5e-08 ...) This PR loosens the tolerance for that test slightly (to 1e-05; 1e-06 or 1e-07 would probably be sufficient but I don't think it hurts to leave it at 1e-05). Since this is a tiny change you could always reject the PR and change the tolerance setting however you preferred ...