Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login): use correct time for isLocked check #6052

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Sjoertjuh
Copy link

Description

Fixes #4950

The time given to the isLocked function is an ISO string because of the implementation of the incrementLoginAttempts function, even though it expects milliseconds since epoch. For this reason the isLocked function will never return true.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added fixed tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation (none)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account locking failure
1 participant