feat(plugin-stripe): update plugin stripe for v3 #6019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpopus
changed the title
DanRibbens
previously requested changes
Apr 30, 2024
denolfe
requested changes
May 2, 2024
There was a problem hiding this comment.
Looks like quite a few things need to be updated in the package.json to be on par with our other packages.
You'll want to format the package.json first then you can compare easily. (this was added after you branched looks like).
pnpx sort-package-json "packages/plugin-stripe/package.json"
A few things I noticed right away:
- Need to re-enable the build (this was disabled until it could build succesfully)
- Ensure
exportsandpublishConfigmatches others - remove unused
testnpm script, no unit tests in this package - remove unused devDeps (react, webpack, prettier, etc)
denolfe
changed the title
denolfe
approved these changes
May 2, 2024
denolfe
dismissed
DanRibbens’s stale review
Will be using named exports for all plugins from now on.
paulpopus
added a commit
that referenced
this pull request
May 6, 2024
JessChowdhury
pushed a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the stripe plugin for v3
Type of change