Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collection labels with multiple locales showing incorrectly #5998

Merged
merged 4 commits into from May 14, 2024

Conversation

JessChowdhury
Copy link
Member

Description

Duplicate of this PR for 3.0.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Existing test suite passes locally with my changes

@JessChowdhury JessChowdhury changed the title fix(3.0): collection labels with multiple locales showing incorrectly fix(beta): collection labels with multiple locales showing incorrectly Apr 24, 2024
@JessChowdhury JessChowdhury changed the title fix(beta): collection labels with multiple locales showing incorrectly fix: collection labels with multiple locales showing incorrectly Apr 24, 2024
Copy link
Member

@AlessioGr AlessioGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Just added a small simplification to avoid creating a new function, since getTranslation passes through strings anyways

@AlessioGr AlessioGr enabled auto-merge (squash) May 14, 2024 14:46
@AlessioGr AlessioGr merged commit 58bbbbd into beta May 14, 2024
33 of 34 checks passed
@AlessioGr AlessioGr deleted the fix/3.0/localized-create-new-label branch May 14, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants