Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Nested Docs URL conflicts #5907

Closed

Conversation

sarfarazsiddiquii
Copy link

@sarfarazsiddiquii sarfarazsiddiquii commented Apr 18, 2024

Description

The issue (ref #5879) existed due to the code was only considering the last part of the slug to fetch the page. ref examples\nested-docs\next-app\app\[...slug]\page.tsx

The fix was to use the full path of the slug to fetch the page.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Existing test suite passes locally with my changes

@sarfarazsiddiquii
Copy link
Author

@denolfe i belive the issue is solved can you please review it and tell me if any changes are required.
Thanks

@denolfe
Copy link
Member

denolfe commented May 1, 2024

Examples will be reworked for 3.0. If still an issue after, feel free to open a new PR.

@denolfe denolfe closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants