Create 4.x branch in preparation for a 4.0.5 release #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ffd9159)
(cherry picked from commit 0d262f7)
(cherry picked from commit 91630bd)
(cherry picked from commit 8c05d86)
(cherry picked from commit 35697bc)
(cherry picked from commit 2fe8804)
…ssfish Server)
Needed some modifications for request-filename condition to got it
working well on Payara Glassfish Server.
urlrewrite.xml rule:
<rule>
<name>HTML5 Redirect</name>
<condition type="request-filename" operator="notfile"></condition>
<condition type="request-filename" operator="notdir"></condition>
<from>^((?!rest).)*$</from>
<to type="redirect">%{context-path}/index.html</to>
</rule>
(cherry picked from commit d652dad)
…Glassfish Server) Needed some modifications for request-filename condition to got it working well on Payara Glassfish Server. urlrewrite.xml rule: <rule> <name>HTML5 Redirect</name> <condition type="request-filename" operator="notfile"></condition> <condition type="request-filename" operator="notdir"></condition> <from>^((?!rest).)*$</from> <to type="redirect">/index.html</to> </rule> (cherry picked from commit b651500)
(cherry picked from commit a42a84b)
(cherry picked from commit dfbba1a)
(cherry picked from commit 9dbe8c5)
Duplicate headers from this filter influenced CORS behaviour (ticket paultuckey#228) (cherry picked from commit 4acda02)
(cherry picked from commit 831300e)
…d_rewrite-style conf files. (cherry picked from commit 03e0713)
(cherry picked from commit c0a7620)
(cherry picked from commit feaa3e2)
(cherry picked from commit 923e90e)
(cherry picked from commit bccdf19)
(cherry picked from commit 358ce15)
Bumps [junit](https://github.com/junit-team/junit4) from 4.9 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md) - [Commits](junit-team/junit4@r4.9...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 4810348)
Bumps [junit](https://github.com/junit-team/junit4) from 4.9 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md) - [Commits](junit-team/junit4@r4.9...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit b260562)
Bumps [junit](https://github.com/junit-team/junit4) from 4.9 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md) - [Commits](junit-team/junit4@r4.9...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 189a694)
(cherry picked from commit 15ad02b)
(cherry picked from commit 5d6c290)
(cherry picked from commit 51369d2)
(cherry picked from commit ae3b449)
(cherry picked from commit bbf3329)
(cherry picked from commit 5519d39)
(cherry picked from commit 9760803)
(cherry picked from commit 520b690)
(cherry picked from commit 1501e9f)
(cherry picked from commit f4293f8)
(cherry picked from commit 59107fb)
(cherry picked from commit 58962ac)
(cherry picked from commit bd905bd)
(cherry picked from commit b6eb067)
(cherry picked from commit 9b35a66)
(cherry picked from commit f70c8a6)
Bumps ant from 1.7.0 to 1.10.11. --- updated-dependencies: - dependency-name: org.apache.ant:ant dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit fac9851)
(cherry picked from commit 178650a)
(cherry picked from commit 7817bf2)
(cherry picked from commit 332a831)
(cherry picked from commit 7a8d1bb)
(cherry picked from commit 4247add)
(cherry picked from commit 574906a)
(cherry picked from commit 2eed91f)
(cherry picked from commit ec67926)
|
Actions run for a basic build is passing at https://github.com/chadlwilson/urlrewritefilter/actions/runs/6753709837/job/18360469952 :-) |
chadlwilson
changed the title
|
Hello @paultuckey - as discussed at #191 (comment) I've had a go at this here. Am I on the right track with this? Aside from doing some more sanity testing myself, how might I get it into a state that is easier to maintain and release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methodology
4.xspecificRelative to
4.0.4this should include (ignoring dependabot/dependency updates and docs)Things to note
4.1.xbut that'd be confusing with the docs, as minor releases are documented separately and this doesn't seem desirable.4.xwas targeting Java1.5, but my believe is that this theoretically "breaking" change shouldn't matter so much as Java 7 was EOL on 19 July 2022 with7u351and unlikely to break anyone?mainand will be ignored from this branch.Possible things missed