enable background usage on android with v2 embedding #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCsabaToth
reviewed
Jun 14, 2021
| @@ -158,25 +165,22 @@ private void setup( | |||
| if (registrar != null) { | |||
| // V1 embedding setup for activity listeners. | |||
| registrar.addRequestPermissionsResultListener(this); | |||
| } else { | |||
| // V2 embedding setup for activity listeners. | |||
| activityBinding.addRequestPermissionsResultListener(this); | |||
There was a problem hiding this comment.
I'd like to understand this code more. Why is the V2 embedding removed?
There was a problem hiding this comment.
It was moved to onAttachedToActivity(ActivityPluginBinding binding).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to initialization code, on android because with v2 embedding onAttachedToActivity is not called when using the plugin from within an isolate (tested with isolate_handler and foreground_service).
I also noticed some complications when using the plugin in different isolates, eg. listeners on BluetoothGatt still being called after teardown.