Enable implicit solvers for complex inputs #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok we need a new release of optimistix (specifically patrick-kidger/optimistix#53) for that one |
|
Ah, I'd been wanting to do a new Optimistix release anyway, so that sounds good to me. Just to double check before I do: so far as you know, is Optimistix completely ready on the complex-support front? If so then I'll advertise this in the release notes for it. |
|
I've added some complex-related tests in the PR and it passed and I didn't encounter any issues when I played with it. I didn't take a look at minimization (complex->real functions) though. Maybe advertise it as "experimental support", and I'll be happy to help with bug fixing if there will be any. |
|
@patrick-kidger good to go? |
|
Yup, LGTM! |
patrick-kidger
pushed a commit
that referenced
this pull request
May 19, 2024
* Enable implicit solvers for complex inputs * change version * make pyright happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #388