Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching load_dataset and adding read_csv_kwargs #752

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

martinvonk
Copy link
Collaborator

Short Description

Add @lru_chache decorator to load_dataset and list_dataset to prevent #721
Add settings.json with read_csv kwargs for each file in the dataset.

Checklist before PR can be merged:

@martinvonk martinvonk added the enhancement Indicates improvement of existing features label Apr 30, 2024
@martinvonk martinvonk self-assigned this Apr 30, 2024
@martinvonk martinvonk linked an issue Apr 30, 2024 that may be closed by this pull request
Copy link

codacy-production bot commented Apr 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.13% (target: +0.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ab06d0e) 6254 4737 75.74%
Head commit (b979317) 6301 (+47) 4781 (+44) 75.88% (+0.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#752) 18 18 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates improvement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cache=True to ps.load_dataset
1 participant