Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master branch to Pastas 1.5 #741

Merged
merged 141 commits into from Apr 18, 2024
Merged

Update master branch to Pastas 1.5 #741

merged 141 commits into from Apr 18, 2024

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented Apr 15, 2024

Short Description

Big update for Pastas to version 1.5.

Checklist before PR can be merged:

  • is documented
  • Format code with Black formatting
  • type hints for functions and methods
  • tests added / passed
  • Example Notebook (for new features)
  • Remove output for all notebooks with changes

rubencalje and others added 30 commits January 19, 2024 10:15
where necessary to get same output
…dified (#700)

Co-authored-by: Raoul Collenteur <raoulcollenteur@gmail.com>
This PR also fixes a bug where the use of freq_obs would result in the following error, when saving and reading a model from file again:
ValueError: Weights and observations time series have different lengths! Check observation and simulation time series
@raoulcollenteur raoulcollenteur added this to the 1.5 milestone Apr 15, 2024
@raoulcollenteur raoulcollenteur self-assigned this Apr 15, 2024
@raoulcollenteur raoulcollenteur added the priority 0 high, deal with as soon as possible label Apr 15, 2024
Copy link

codacy-production bot commented Apr 15, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+1.24% (target: +0.00%) 67.73%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b9ef48b) 5975 4459 74.63%
Head commit (35a76fe) 6294 (+319) 4775 (+316) 75.87% (+1.24%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#741) 437 296 67.73%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link
Collaborator

@mbakker7 mbakker7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go. Some minor things in Codacy that can be fixed next time.

pastas/__init__.py Outdated Show resolved Hide resolved
pastas/model.py Outdated Show resolved Hide resolved
pastas/model.py Outdated Show resolved Hide resolved
Copy link
Member

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor comments, one comment about stderrs in interactive plots that can easily be picked up in the next release.

@raoulcollenteur
Copy link
Member Author

Thanks for reviews! Ready to merge after merging #743 into Dev, to add the banner on the homepage as suggested by @mbakker7.

@raoulcollenteur raoulcollenteur merged commit 0a5b1d7 into master Apr 18, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority 0 high, deal with as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants