New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update master branch to Pastas 1.5 #741
Conversation
Based on proposal from @raoulcollenteur in issue #667
where necessary to get same output
…dified (#700) Co-authored-by: Raoul Collenteur <raoulcollenteur@gmail.com>
This PR also fixes a bug where the use of freq_obs would result in the following error, when saving and reading a model from file again: ValueError: Weights and observations time series have different lengths! Check observation and simulation time series
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go. Some minor things in Codacy that can be fixed next time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor comments, one comment about stderrs in interactive plots that can easily be picked up in the next release.
Short Description
Big update for Pastas to version 1.5.
Checklist before PR can be merged: