Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_model method #625

Open
raoulcollenteur opened this issue Sep 4, 2023 · 1 comment
Open

Add check_model method #625

raoulcollenteur opened this issue Sep 4, 2023 · 1 comment
Assignees
Labels
development Indicates development of new features priority 1 normal, deal with in the foreseeable future

Comments

@raoulcollenteur
Copy link
Member

Describe the proposed feature

I propose to add a method that takes in a Pastas model, and checks against possible issues. This could help future users I think.

Expected usage

ps.check_model(ml)

e.g., Returns

  • Response function longer than calibration time
  • Parameter on bound
  • ...
@raoulcollenteur raoulcollenteur added the development Indicates development of new features label Sep 4, 2023
@raoulcollenteur raoulcollenteur added this to the 1.4 milestone Nov 28, 2023
@martinvonk
Copy link
Collaborator

Discussion on this topic: https://github.com/orgs/pastas/discussions/658

@martinvonk martinvonk added the priority 1 normal, deal with in the foreseeable future label Nov 29, 2023
@raoulcollenteur raoulcollenteur modified the milestones: 1.4, 1.5 Feb 16, 2024
@raoulcollenteur raoulcollenteur changed the title [DEVELOPMENT] Add check_model method Add check_model method Apr 9, 2024
@raoulcollenteur raoulcollenteur modified the milestones: 1.5, 2.0: Bolognese Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Indicates development of new features priority 1 normal, deal with in the foreseeable future
Projects
None yet
Development

No branches or pull requests

3 participants