Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signaling colors in table 'model parameters' #568

Open
cjhollebrandse opened this issue Mar 3, 2023 · 4 comments
Open

Add signaling colors in table 'model parameters' #568

cjhollebrandse opened this issue Mar 3, 2023 · 4 comments
Assignees
Labels
development Indicates development of new features help wanted Indicates that a maintainer wants help on an issue or pull request priority 2 low, nice to have feature to be implemented when time's available

Comments

@cjhollebrandse
Copy link

The table 'model parameters' shows the parameters that gives the best fit. It happens that certain parameters deviate considerably from what is physically realistic.
For less advanced users, the interpretation of the model results becomes easier if unrealistic results are given a signaling color (yellow, orange, red). In case of a color code it's advisable to generate a new model or to be careful with conclusions.

I think this is fairly easy to implement.

@cjhollebrandse cjhollebrandse added the development Indicates development of new features label Mar 3, 2023
@dbrakenhoff
Copy link
Member

Thanks @cjhollebrandse for your suggestion! I like the idea of color coding the parameters table.

However, I don´t think we can really determine whether parameters are physically realistic. There's probably no way to include code that would work well in all situations.

Having said that I do think we can use color codes to signal if parameters hit the parameter bounds, for example. And maybe also think of a way of signalling when response times (e.g. t_99) is longer than the oseries. So basically incorporating the warning section in the fit report in the results plots.

@martinvonk martinvonk added the priority 2 low, nice to have feature to be implemented when time's available label Mar 7, 2023
@martinvonk martinvonk changed the title Add signaling colors in table 'model parameters' [DEVELOPMENT] Add signaling colors in table 'model parameters' Mar 7, 2023
@martinvonk martinvonk added the help wanted Indicates that a maintainer wants help on an issue or pull request label Mar 21, 2023
@martinvonk
Copy link
Collaborator

Also related to the question:
how to present standard errors with autocorrelated residuals?

@martinvonk
Copy link
Collaborator

related to #625

@raoulcollenteur raoulcollenteur added this to the 2.0: Bolognese milestone Nov 28, 2023
@martinvonk
Copy link
Collaborator

related to #722

@raoulcollenteur raoulcollenteur changed the title [DEVELOPMENT] Add signaling colors in table 'model parameters' Add signaling colors in table 'model parameters' Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Indicates development of new features help wanted Indicates that a maintainer wants help on an issue or pull request priority 2 low, nice to have feature to be implemented when time's available
Projects
None yet
Development

No branches or pull requests

5 participants