Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use coerceToArrayBuffer to post-process assertion options in Demo js #467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dradovic
Copy link

Just did the todos from the comments.

@dradovic
Copy link
Author

@dotnet-policy-service agree

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (145034a) 73.83% compared to head (6ee9b3a) 73.83%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files          99       99           
  Lines        2710     2710           
  Branches      445      445           
=======================================
  Hits         2001     2001           
  Misses        604      604           
  Partials      105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dradovic
Copy link
Author

Note that there's a subtle change here: by using coerceToArrayBuffer the bytes are copied in a for-loop instead of using Uint8Array.from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants