Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Demo site update #277

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

(WIP) Demo site update #277

wants to merge 18 commits into from

Conversation

aseigler
Copy link
Collaborator

@aseigler aseigler commented Dec 6, 2021

  • Improvements mostly to custom area of demo, lots more options (inspired largely by https://webauthntest.azurewebsites.net)
  • Default everywhere to UV = discouraged
  • Integrate info from MDS when AAGUID is available
  • Prioritize Ed25519 when available

@aseigler aseigler added the enhancement Enhancements or general improvements label Dec 6, 2021
@aseigler aseigler self-assigned this Dec 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #277 (45af0e4) into master (dd727b1) will decrease coverage by 0.30%.
The diff coverage is 67.27%.

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   77.87%   77.56%   -0.31%     
==========================================
  Files          88       88              
  Lines        2495     2510      +15     
  Branches      415      417       +2     
==========================================
+ Hits         1943     1947       +4     
- Misses        439      447       +8     
- Partials      113      116       +3     
Impacted Files Coverage Δ
...ls/Objects/AuthenticationExtensionsClientInputs.cs 20.00% <ø> (ø)
...s/Objects/AuthenticationExtensionsClientOutputs.cs 100.00% <ø> (ø)
Src/Fido2/AuthenticatorAttestationResponse.cs 85.84% <50.00%> (-0.69%) ⬇️
Src/Fido2.Models/CredentialCreateOptions.cs 40.90% <59.09%> (-0.96%) ⬇️
Src/Fido2/CryptoUtils.cs 81.90% <74.19%> (-6.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abergs
Copy link
Collaborator

abergs commented Jul 31, 2023

@aseigler I've done some PR's that has overlap with this pr.

Instead of fixing "everything" in this PR and deal with the ongoing rebasing etc, I might try to re-implement some stuff you've done and put it in smaller PR's

@aseigler
Copy link
Collaborator Author

@aseigler I've done some PR's that has overlap with this pr.

Instead of fixing "everything" in this PR and deal with the ongoing rebasing etc, I might try to re-implement some stuff you've done and put it in smaller PR's

Totally agree. This one got way out of control.

@abergs abergs marked this pull request as draft November 10, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements or general improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants