Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Secrets alongside resources if required #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

speatzle
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PiMaDaum
Copy link
Contributor

Hi @speatzle
I looked at your changes here. I have noticed, that you added a condition, where you check, if users set secret columns, and then you load this values over new function in the api.
In your condition, you're using lowercase of column names. In the help description of switch -c all column names are in camel case. I think users will be guided by the help and will use camel case too.

@speatzle
Copy link
Collaborator Author

speatzle commented Feb 22, 2023

@PiMaDaum
hi, thanks for the tip, this was just a rough proof of concept and i forgot to strings.lower case the input. but i will need to redo this PR based on your filter PR's Changes anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants