Reflecting boundary conditions #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrete
reviewed
May 5, 2023
Comment on lines
+22
to
+53
| // Function for checking boundary flags: is this a domain or internal bound? | ||
| // | ||
| inline bool IsDomainBound(parthenon::MeshBlock *pmb, parthenon::BoundaryFace face) { | ||
| return !(pmb->boundary_flag[face] == parthenon::BoundaryFlag::block || | ||
| pmb->boundary_flag[face] == parthenon::BoundaryFlag::periodic); | ||
| } | ||
|
|
||
| // Get zones which are inside the physical domain, i.e. set by computation or MPI halo | ||
| // sync, not by problem boundary conditions. | ||
| // | ||
| inline auto GetPhysicalZones(parthenon::MeshBlock *pmb, parthenon::IndexShape &bounds) | ||
| -> std::tuple<parthenon::IndexRange, parthenon::IndexRange, parthenon::IndexRange> { | ||
| return std::tuple<parthenon::IndexRange, parthenon::IndexRange, parthenon::IndexRange>{ | ||
| parthenon::IndexRange{IsDomainBound(pmb, parthenon::BoundaryFace::inner_x1) | ||
| ? bounds.is(parthenon::IndexDomain::interior) | ||
| : bounds.is(parthenon::IndexDomain::entire), | ||
| IsDomainBound(pmb, parthenon::BoundaryFace::outer_x1) | ||
| ? bounds.ie(parthenon::IndexDomain::interior) | ||
| : bounds.ie(parthenon::IndexDomain::entire)}, | ||
| parthenon::IndexRange{IsDomainBound(pmb, parthenon::BoundaryFace::inner_x2) | ||
| ? bounds.js(parthenon::IndexDomain::interior) | ||
| : bounds.js(parthenon::IndexDomain::entire), | ||
| IsDomainBound(pmb, parthenon::BoundaryFace::outer_x2) | ||
| ? bounds.je(parthenon::IndexDomain::interior) | ||
| : bounds.je(parthenon::IndexDomain::entire)}, | ||
| parthenon::IndexRange{IsDomainBound(pmb, parthenon::BoundaryFace::inner_x3) | ||
| ? bounds.ks(parthenon::IndexDomain::interior) | ||
| : bounds.ks(parthenon::IndexDomain::entire), | ||
| IsDomainBound(pmb, parthenon::BoundaryFace::outer_x3) | ||
| ? bounds.ke(parthenon::IndexDomain::interior) | ||
| : bounds.ke(parthenon::IndexDomain::entire)}}; | ||
| } |
There was a problem hiding this comment.
Is this code actually used somewhere?
There was a problem hiding this comment.
This is used in my precipitator pgen. I could move it there if you don't want to include it here.
|
|
||
| using parthenon::Real; | ||
|
|
||
| void ReflectingInnerX3(std::shared_ptr<parthenon::MeshBlockData<Real>> &mbd, |
There was a problem hiding this comment.
Any reason to not template this (for different dims) already now?
Comment on lines
+87
to
+89
| std::string label = (TYPE == BCType::Reflect ? "Reflect" : "Outflow"); | ||
| label += (INNER ? "Inner" : "Outer"); | ||
| label += "X" + std::to_string(DIR); |
There was a problem hiding this comment.
No need for outflow here but maybe add "AthenaPK" to the label.
| label, nvar, domain, coarse, | ||
| KOKKOS_LAMBDA(const int &l, const int &k, const int &j, const int &i) { | ||
| if (!q.IsAllocated(l)) return; | ||
| if (TYPE == BCType::Reflect) { |
There was a problem hiding this comment.
We can probably skip this TYPE and just call this method `ApplyReflectBC``
|
For tests, are you thinking of a simulation that would run and then we would check the solution, or just a unit test to check that the ghost cells are filled correctly for a given example of interior cells? |
Closed
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #56.
Only X3-boundaries are implemented. The boundary functions must be manually enrolled by the problem generator.